Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deletion posts in user profile management #6729

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 29, 2024

What type of PR is this?

/kind feature
/milestone 2.20.x
/area core
/kind api-change

What this PR does / why we need it:

新增 API 用于删除自己的文章

Which issue(s) this PR fixes:

Fixes #5851

Does this PR introduce a user-facing change?

支持在个人中心的文章管理界面删除用户创建的文章

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 29, 2024
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Sep 29, 2024
Copy link

f2c-ci-robot bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing
Copy link
Member Author

guqing commented Sep 29, 2024

@ruibaby 帮忙适配一下个人中心的文章管理,支持删除

@guqing guqing changed the title feat: add API for recycle users own posts feat: support deletion posts in user profile management Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 58.00%. Comparing base (982a45b) to head (5b2bdfd).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...ava/run/halo/app/content/impl/PostServiceImpl.java 0.00% 4 Missing ⚠️
.../run/halo/app/core/endpoint/uc/UcPostEndpoint.java 60.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6729      +/-   ##
============================================
- Coverage     58.29%   58.00%   -0.29%     
- Complexity     3963     3977      +14     
============================================
  Files           680      696      +16     
  Lines         23338    23517     +179     
  Branches       1584     1567      -17     
============================================
+ Hits          13604    13641      +37     
- Misses         9108     9255     +147     
+ Partials        626      621       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

pkg-pr-new bot commented Sep 29, 2024

Open in Stackblitz

@halo-dev/api-client

pnpm add https://pkg.pr.new/@halo-dev/api-client@6729

@halo-dev/components

pnpm add https://pkg.pr.new/@halo-dev/components@6729

@halo-dev/richtext-editor

pnpm add https://pkg.pr.new/@halo-dev/richtext-editor@6729

@halo-dev/console-shared

pnpm add https://pkg.pr.new/@halo-dev/console-shared@6729

@halo-dev/ui-plugin-bundler-kit

pnpm add https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@6729

commit: 5b2bdfd

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2024
Copy link

sonarcloud bot commented Sep 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望作者权限下,也可删除作者自己文章
2 participants