Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unified empty state UI action button styles #6704

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 26, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.20.x

What this PR does / why we need it:

统一空状态界面中操作按钮的风格。

Does this PR introduce a user-facing change?

统一空状态界面中操作按钮的风格。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 26, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 26, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 26, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.18%. Comparing base (6cd8dc8) to head (03fd992).
Report is 88 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##               main    #6704     +/-   ##
===========================================
  Coverage     58.18%   58.18%             
- Complexity     3774     3944    +170     
===========================================
  Files           651      679     +28     
  Lines         22125    23216   +1091     
  Branches       1538     1582     +44     
===========================================
+ Hits          12873    13508    +635     
- Misses         8641     9084    +443     
- Partials        611      624     +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link

f2c-ci-robot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 565dc1c into halo-dev:main Sep 26, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants