Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorganize package structure in application project #6691

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 23, 2024

What type of PR is this?

/milestone 2.20.x
/area core

What this PR does / why we need it:

整理 application 项目的包结构

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note-none Denotes a PR that doesn't merit a release note. labels Sep 23, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 23, 2024
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
Copy link

f2c-ci-robot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.14%. Comparing base (6cd8dc8) to head (792e0dd).
Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/run/halo/app/theme/service/ThemeUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6691      +/-   ##
============================================
- Coverage     58.18%   58.14%   -0.04%     
- Complexity     3774     3942     +168     
============================================
  Files           651      679      +28     
  Lines         22125    23216    +1091     
  Branches       1538     1582      +44     
============================================
+ Hits          12873    13500     +627     
- Misses         8641     9092     +451     
- Partials        611      624      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing merged commit 0336828 into halo-dev:main Sep 23, 2024
6 of 8 checks passed
@guqing guqing deleted the chore/package branch September 23, 2024 09:59
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants