Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve 403 error on menu page when system config access is missing #6688

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 23, 2024

What type of PR is this?

/kind feature
/milestone 2.20.x
/area core

What this PR does / why we need it:

本 PR 通过新增用于根据 Group 获取系统配置的 API 来将获取主菜单的配置绑定到菜单查看角色

Fixes #6468

Does this PR introduce a user-facing change?

修复仅分配菜单权限时菜单页面报 403 错误的问题

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 23, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 23, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 23, 2024
@guqing guqing marked this pull request as draft September 23, 2024 07:57
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@guqing
Copy link
Member Author

guqing commented Sep 23, 2024

@ruibaby 生成一下 api-client 并将菜单处获取系统配置的方式改为使用此 PR 提供的 API

@guqing guqing changed the title feat: add API to fetch system configs by group fix: resolve 403 error on menu page when system config access is missing Sep 23, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.

Project coverage is 58.17%. Comparing base (0dcab32) to head (c945a94).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
...n/halo/app/core/endpoint/SystemConfigEndpoint.java 69.56% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6688      +/-   ##
============================================
+ Coverage     58.12%   58.17%   +0.04%     
+ Complexity     3954     3947       -7     
============================================
  Files           680      680              
  Lines         23217    23262      +45     
  Branches       1579     1582       +3     
============================================
+ Hits          13496    13532      +36     
- Misses         9097     9106       +9     
  Partials        624      624              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 24, 2024

Copy link

pkg-pr-new bot commented Sep 24, 2024

Open in Stackblitz

@halo-dev/components

pnpm add https://pkg.pr.new/@halo-dev/components@6688

@halo-dev/api-client

pnpm add https://pkg.pr.new/@halo-dev/api-client@6688

@halo-dev/richtext-editor

pnpm add https://pkg.pr.new/@halo-dev/richtext-editor@6688

@halo-dev/console-shared

pnpm add https://pkg.pr.new/@halo-dev/console-shared@6688

@halo-dev/ui-plugin-bundler-kit

pnpm add https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@6688

commit: c945a94

@ruibaby ruibaby marked this pull request as ready for review September 24, 2024 04:54
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG September 24, 2024 04:54
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@JohnNiang JohnNiang added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Sep 28, 2024
Copy link

f2c-ci-robot bot commented Sep 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2024
@JohnNiang JohnNiang merged commit 9305fd5 into halo-dev:main Sep 28, 2024
9 of 10 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

当只分配了菜单管理而没有系统配置权限时菜单管理页面会报 403 错误
3 participants