Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: refine display name of system default role #3280

Merged
merged 3 commits into from
Feb 10, 2023
Merged

perf: refine display name of system default role #3280

merged 3 commits into from
Feb 10, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 10, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

为系统初始化的角色添加显示名称

Which issue(s) this PR fixes:

Fixes #3257

Screenshots:

image

Special notes for your reviewer:

see

Does this PR introduce a user-facing change?

为系统初始化的角色添加显示名称

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 10, 2023
@ruibaby ruibaby mentioned this pull request Feb 10, 2023
Merged
@ruibaby
Copy link
Member Author

ruibaby commented Feb 10, 2023

/cherrypick release-2.2

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guqing
guqing reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
JohnNiang
JohnNiang approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.
/approve
image

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang
Copy link
Member

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 3de9f7f into halo-dev:main Feb 10, 2023
@JohnNiang
Copy link
Member

有一个问题可能需要注意一下，搜索功能可能需要适配一下。

image

@halo-dev-bot halo-dev-bot mentioned this pull request Feb 10, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #3284

In response to this:

/cherrypick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby deleted the perf/role-display-name branch February 10, 2023 08:43
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 10, 2023
@halo-dev-bot
[release-2.2] perf: refine display name of system default role (#3284)
5b4d65b 
This is an automated cherry-pick of #3280

/assign ruibaby

```release-note
为系统初始化的角色添加显示名称
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 15, 2023
f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this pull request Feb 15, 2023
@ruibaby
fix: the issue that role display name (#847)
aca67f6 
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

为系统初始化的角色添加显示名称

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#3257

#### Screenshots:

<img width="1668" alt="image" src="https://user-images.githubusercontent.com/21301288/218020794-696420c4-69bb-4422-9409-482bb2aff708.png">


#### Special notes for your reviewer:

测试方式：

1. Halo 需要切换到：halo-dev/halo#3280
2. 检查 Console 端显示的系统角色是否正常。
3. 新建若干自定义角色，检查名称是否正常。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端用户角色标识的显示名称。
```
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@ruibaby
fix: the issue that role display name (halo-dev/console#847)
fce581b 
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

为系统初始化的角色添加显示名称

#### Which issue(s) this PR fixes:

Fixes halo-dev#3257

#### Screenshots:

<img width="1668" alt="image" src="https://user-images.githubusercontent.com/21301288/218020794-696420c4-69bb-4422-9409-482bb2aff708.png">


#### Special notes for your reviewer:

测试方式：

1. Halo 需要切换到：halo-dev#3280
2. 检查 Console 端显示的系统角色是否正常。
3. 新建若干自定义角色，检查名称是否正常。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端用户角色标识的显示名称。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@JohnNiang JohnNiang

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

用户角色标识无法正常显示角色名称
4 participants
@ruibaby @halo-dev-bot @JohnNiang @guqing