Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2.1 tags 标签的路由没有注册 #3321

Closed
guqing opened this issue Feb 15, 2023 · 0 comments · Fixed by #3322
Closed

2.2.1 tags 标签的路由没有注册 #3321

guqing opened this issue Feb 15, 2023 · 0 comments · Fixed by #3322
Assignees
@guqing
Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
2.2.2

Comments

@guqing
Copy link
Member

guqing commented Feb 15, 2023

是什么版本出现了此问题？

2.2.1

使用的什么数据库？

H2

使用的哪种方式部署？

Docker

在线站点地址

No response

发生了什么？

由于 #3316 的改动忽略了路由注册问题，TagReconciler 在系统启动时没有 sync all 会导致 tag 的路由没有注册，因此需要使用新的 Reconciler 来注册路有，它只有很轻的逻辑，需要快速执行每一个。

相关日志输出

No response

附加信息

/kind bug
/area core
/milestone 2.2.x
/assign
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 15, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.2.x milestone Feb 15, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 15, 2023
@JohnNiang JohnNiang added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Feb 15, 2023
@guqing guqing mentioned this issue Feb 15, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Feb 15, 2023
@guqing
fix: route for the tag is not registered when halo starts (#3322)
3cde340 
#### What type of PR is this?
/kind bug
/area core
/milestone 2.3.x

#### What this PR does / why we need it:
1. 去掉原 TagReconciler 的 requeue 逻辑，来临时解决大量 tag 时 reconciler 空转导致 cpu 下不来的问题，参考： #3311
2. 增加 TagRouteReconciler 在启动时注册路由

#### Which issue(s) this PR fixes:
Fixes #3321

#### Special notes for your reviewer:
/cc @halo-dev/sig-halo 
#### Does this PR introduce a user-facing change?
```release-note
修复 #3316 引入的 tags 标签的路由没有注册的问题
```
@JohnNiang JohnNiang modified the milestones: 2.2.x, 2.2.2 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
2.2.2
Development

Successfully merging a pull request may close this issue.

fix: route for the tag is not registered when halo starts guqing/halo
2 participants
@JohnNiang @guqing