Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: mute the start plugin request in setup page #897

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 1, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

隐藏在初始化页面启用插件时的错误提示,因为会重试三次,所以不需要提示。

None

@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 1, 2023 at 4:04AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 1, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 6143f5f into halo-dev:main Mar 1, 2023
@ruibaby ruibaby added this to the 2.3.0 milestone Mar 1, 2023
JohnNiang added a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
Signed-off-by: johnniang <johnniang@fastmail.com>
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

隐藏在初始化页面启用插件时的错误提示,因为会重试三次,所以不需要提示。

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants