Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: user filter list will fail to load the avatar after searching #885

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 24, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复用户筛选列表在搜索之后无法正常加载头像的问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3361

Screenshots:

image

Special notes for your reviewer:

测试方式:

  1. 创建若干用户并设置头像。
  2. 打开文章管理的用户筛选项,尝试输入关键词搜索,观察搜索出的用户头像是否加载正常。

Does this PR introduce a user-facing change?

修复 Console 端用户筛选项,输入关键词搜索之后无法加载头像的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 24, 2023
@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 6:49AM (UTC)

@LIlGG
Copy link
Member

LIlGG commented Feb 24, 2023

/lgtm

经过测试,可以正常显示用户头像。

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit dc9c606 into halo-dev:main Feb 24, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 24, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…alo-dev/console#885)

#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修复用户筛选列表在搜索之后无法正常加载头像的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3361

#### Screenshots:

<img width="455" alt="image" src="https://user-images.githubusercontent.com/21301288/221108789-291999ab-ee4f-478c-900b-4273e3780357.png">

#### Special notes for your reviewer:
 
测试方式:

1. 创建若干用户并设置头像。
2. 打开文章管理的用户筛选项,尝试输入关键词搜索,观察搜索出的用户头像是否加载正常。

#### Does this PR introduce a user-facing change?


```release-note
修复 Console 端用户筛选项,输入关键词搜索之后无法加载头像的问题。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文章筛选使用作者筛选时,输入作者名称输出的作者有的头像不显示
4 participants