Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: improve the conditions for categories and tags automatic refresh #883

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 24, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

优化分类和标签管理页面自动刷新的条件,现在支持检测 status.permalink 是否已经生成完毕,如果没有会自动刷新列表。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3376

Special notes for your reviewer:

测试方式:

  1. 测试添加若干分类和标签,观测在没有生成 permalink 的情况下,是否会自动刷新列表。

Does this PR introduce a user-facing change?

优化 Console 端分类和标签管理的自动刷新条件,支持检测固定链接是否已经生成。

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 6:20AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 24, 2023
@LIlGG
Copy link
Member

LIlGG commented Feb 24, 2023

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit a8166e5 into halo-dev:main Feb 24, 2023
@ruibaby ruibaby deleted the perf/category-auto-fetch branch February 24, 2023 06:41
@ruibaby ruibaby added this to the 2.3.0 milestone Feb 24, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
halo-dev/console#883)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

优化分类和标签管理页面自动刷新的条件,现在支持检测 `status.permalink` 是否已经生成完毕,如果没有会自动刷新列表。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3376

#### Special notes for your reviewer:

测试方式:

1. 测试添加若干分类和标签,观测在没有生成 permalink 的情况下,是否会自动刷新列表。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端分类和标签管理的自动刷新条件,支持检测固定链接是否已经生成。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

标签和分类在添加之后建议提供自动刷新列表的功能
3 participants