Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: remove default cover from user profile page #881

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 23, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

因为暂时不太好为用户设置个人资料背景图片,所以暂时移除个人资料页面的默认背景。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#2851

Screenshots:

image

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

移除 Console 端个人资料页面的默认背景图片

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 23, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wzrove February 23, 2023 08:07
@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 8:09AM (UTC)

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@LIlGG
Copy link
Member

LIlGG commented Feb 23, 2023

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 5a27f56 into halo-dev:main Feb 23, 2023
@ruibaby ruibaby deleted the refactor/user-profile-page branch February 23, 2023 10:22
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 24, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…le#881)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

因为暂时不太好为用户设置个人资料背景图片,所以暂时移除个人资料页面的默认背景。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2851

#### Screenshots:

<img width="1680" alt="image" src="https://user-images.githubusercontent.com/21301288/220852412-6732c965-ae43-441e-b99a-af3d6d978d4f.png">


#### Special notes for your reviewer:

None

#### Does this PR introduce a user-facing change?

```release-note
移除 Console 端个人资料页面的默认背景图片
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console端个人资料编辑页面顶部背景不能自定义
3 participants