Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: default value of formkit schema is not initialize in annotation form #880

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Feb 23, 2023

What type of PR is this?

/kind bug
/milestone 2.3.x
/area console

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3357

Special notes for your reviewer:

测试使用主题/插件自定义的元数据信息,是否能够在 console 中显示默认值。

Does this PR introduce a user-facing change?

使用主题/插件配置的元数据将能够展示默认值

@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 4:26AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 23, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.x milestone Feb 23, 2023
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2023

CLA assistant check
All committers have signed the CLA.

@ruibaby ruibaby changed the title fix: support metadata default display fix: default value of formkit schema is not initialize in annotation form Feb 23, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 1f8cf9f into halo-dev:main Feb 23, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 23, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…form (halo-dev/console#880)

#### What type of PR is this?
/kind bug
/milestone 2.3.x
/area console

#### What this PR does / why we need it:

#### Which issue(s) this PR fixes:
Fixes halo-dev#3357

#### Special notes for your reviewer:
测试使用主题/插件自定义的元数据信息,是否能够在 console 中显示默认值。

#### Does this PR introduce a user-facing change?

```release-note
使用主题/插件配置的元数据将能够展示默认值
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

元数据表单定义的默认值不生效
4 participants