Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: support configuring plugin when the plugin is stopped #875

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 21, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

  1. 插件停止时支持配置插件设置项。
  2. 修改插件异常信息的获取方式。

适配:halo-dev/halo#3355

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3352

Special notes for your reviewer:

测试方式:

  1. Halo 需要切换到 feat: plugin supports configuration when not started halo#3355 分支。
  2. Console 需要 pnpm build:packages
  3. 根据 feat: plugin supports configuration when not started halo#3355 中的描述进行测试。

Does this PR introduce a user-facing change?

None

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 9:34AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 21, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing February 21, 2023 09:32
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
image
image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@ruibaby ruibaby added this to the 2.3.x milestone Feb 24, 2023
@JohnNiang JohnNiang changed the title refactor: support configure when plugin is stopped refactor: support configuring plugin when the plugin is stopped Feb 24, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 08c58ae into halo-dev:main Feb 24, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 24, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…-dev/console#875)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

1. 插件停止时支持配置插件设置项。
2. 修改插件异常信息的获取方式。

适配:halo-dev#3355

#### Which issue(s) this PR fixes:

Fixes halo-dev#3352

#### Special notes for your reviewer:

测试方式:

1. Halo 需要切换到 halo-dev#3355 分支。
2. Console 需要 `pnpm build:packages`
3. 根据 halo-dev#3355 中的描述进行测试。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

请求允许插件在未启动时更改设置
3 participants