This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
perf: disable the editor from pasting excel tables as pictures #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/lgtm |
wzrove
approved these changes
Feb 21, 2023
|
ping @halo-dev/sig-halo-console |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, wan92hen, wzrove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…dev/console#873) #### What type of PR is this? /kind improvement #### What this PR does / why we need it: 禁止在编辑器粘贴 Excel 表格时，将表格转为图片的形式上传。 #### Which issue(s) this PR fixes: Fixes halo-dev#3348 #### Screenshots: before: <img width="818" alt="image" src="https://user-images.githubusercontent.com/21301288/220243681-eb07502a-0fc5-4e69-9cd3-61c3b89cb542.png"> after: <img width="815" alt="image" src="https://user-images.githubusercontent.com/21301288/220243630-ca7c2700-ff61-4893-a857-94860e4a899b.png"> #### Special notes for your reviewer: 测试方式： 1. 使用 Excel 或者 macOS 下的 Numbers 创建一个表格。 2. 复制整个表格或者某几个单元格，并粘贴到 Halo 的编辑器。 3. 观察是否有将内容转为图片并上传。 #### Does this PR introduce a user-facing change? ```release-note Console 端禁止在编辑器粘贴 Excel 表格以图片的形式上传。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
禁止在编辑器粘贴 Excel 表格时，将表格转为图片的形式上传。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#3348
Screenshots:
before:
after:
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?