Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

feat: add supports for display database info in actuator page #872

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 20, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

支持在系统概览页面显示数据库信息。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3263

Screenshots:

image

Special notes for your reviewer:

测试方式:

  1. Halo 需要切换到 feat: add database endpoint for actuator halo#3351 分支。
  2. 进入系统概览页面,检查是否有数据库信息。

Does this PR introduce a user-facing change?

Console 端的系统概览页面支持显示数据库信息

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 20, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and guqing February 20, 2023 13:21
@vercel
Copy link

vercel bot commented Feb 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 3:33AM (UTC)

@ruibaby ruibaby added this to the 2.3.x milestone Feb 21, 2023
@LIlGG
Copy link
Member

LIlGG commented Feb 21, 2023

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 43702ed into halo-dev:main Feb 21, 2023
@ruibaby ruibaby deleted the feat/actuator-database branch February 21, 2023 04:20
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 23, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…ev/console#872)

#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

支持在系统概览页面显示数据库信息。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3263

#### Screenshots:

<img width="1413" alt="image" src="https://user-images.githubusercontent.com/21301288/220119998-dcf58a6e-cbe5-46ed-9fda-67d0ce5b85c1.png">

#### Special notes for your reviewer:

测试方式:

1. Halo 需要切换到 halo-dev#3351 分支。
2. 进入系统概览页面,检查是否有数据库信息。

#### Does this PR introduce a user-facing change?

```release-note
Console 端的系统概览页面支持显示数据库信息
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议控制台概览界面新增数据库版本等信息展示
4 participants