Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: mute the fetch roles request #857

Merged
merged 1 commit into from
Feb 15, 2023
Merged

perf: mute the fetch roles request #857

merged 1 commit into from
Feb 15, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 15, 2023 •
edited by JohnNiang
Loading

What type of PR is this?

/kind improvement

What this PR does / why we need it:

静默请求所有角色信息，用于显示 displayName。（临时解决方案）

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 15, 2023
@vercel
Copy link

vercel bot commented Feb 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 8:02AM (UTC)

@ruibaby
Copy link
Member Author

ruibaby commented Feb 15, 2023

/cherry-pick release-note

@halo-dev-bot
Copy link

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-note in a new PR and assign it to you.

In response to this:

/cherry-pick release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby
Copy link
Member Author

ruibaby commented Feb 15, 2023

/cherry-pick release-2.2

@halo-dev-bot
Copy link

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guqing
guqing reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
wzrove
wzrove approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@wzrove wzrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

JohnNiang
JohnNiang approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, wzrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit fe353a4 into halo-dev:main Feb 15, 2023
@halo-dev-bot
Copy link

@ruibaby: cannot checkout release-note: error checking out release-note: exit status 1. output: error: pathspec 'release-note' did not match any file(s) known to git

In response to this:

/cherry-pick release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot halo-dev-bot mentioned this pull request Feb 15, 2023
Merged
@halo-dev-bot
Copy link

@ruibaby: new pull request created: #858

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 15, 2023
@halo-dev-bot
[release-2.2] perf: mute the fetch roles request (#858)
5332839 
This is an automated cherry-pick of #857

/assign ruibaby

```release-note
None
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 15, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
@ruibaby
perf: mute the fetch roles request (halo-dev/console#857)
e9970b2 
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

静默请求所有角色信息，用于显示 displayName。（临时解决方案）

#### Does this PR introduce a user-facing change?


```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@wzrove wzrove wzrove approved these changes

@QuentinHsu QuentinHsu Awaiting requested review from QuentinHsu

Assignees

@guqing guqing

@wzrove wzrove

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ruibaby @halo-dev-bot @JohnNiang @guqing @wzrove