Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

perf: improve word-break style for comment content #852

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 13, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

修复评论管理中内容文字过长导致样式异常的问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3294

Screenshots:

before:

image

after:

image

Does this PR introduce a user-facing change?

修复 Console 的评论管理中内容文字过长导致样式异常的问题。

@vercel
Copy link

vercel bot commented Feb 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 6:24AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Feb 13, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove February 13, 2023 05:42
@ruibaby ruibaby added this to the 2.3.x milestone Feb 13, 2023
@wan92hen
Copy link
Contributor

这个宽度是不是不太够,还有比较多空白的地方。

@ruibaby
Copy link
Member Author

ruibaby commented Feb 13, 2023

这个宽度是不是不太够,还有比较多空白的地方。

image

已调整。

@wan92hen
Copy link
Contributor

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
Copy link
Member

@wzrove wzrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, wzrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 381c3e2 into halo-dev:main Feb 13, 2023
@ruibaby ruibaby deleted the perf/comment-content-break branch February 13, 2023 09:08
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 21, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

修复评论管理中内容文字过长导致样式异常的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3294

#### Screenshots:

before:

<img width="1016" alt="image" src="https://user-images.githubusercontent.com/21301288/218379816-73a39f13-32f7-40a8-a65d-9e7f6f691f71.png">

after:

<img width="1416" alt="image" src="https://user-images.githubusercontent.com/21301288/218379719-f86193c0-d6d7-4aa6-ad5c-d538c215e80b.png">

#### Does this PR introduce a user-facing change?


```release-note
修复 Console 的评论管理中内容文字过长导致样式异常的问题。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端的评论管理中内容过长导致样式问题。
4 participants