Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: menu scroll bar is blocked #845

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

longjuan
Copy link
Member

@longjuan longjuan commented Feb 10, 2023

What type of PR is this?

/kind improvement
/area console

What this PR does / why we need it:

使左侧菜单栏滚动条不被遮挡

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3272

Screenshots:

image
image
image

Special notes for your reviewer:

分为logo、可滚动(搜索、菜单)、用户信息三部分,不妥就关闭这个PR吧

Does this PR introduce a user-facing change?

完整显示左侧菜单栏滚动条

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 10, 2023
@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 10, 2023 at 4:03AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/console labels Feb 10, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wzrove February 10, 2023 04:01
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice Work!

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 3724a45 into halo-dev:main Feb 10, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 10, 2023
@ruibaby
Copy link
Member

ruibaby commented Feb 15, 2023

/cherrypick release-2.2

@halo-dev-bot
Copy link

@ruibaby: new pull request created: #855

In response to this:

/cherrypick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 15, 2023
This is an automated cherry-pick of #845

/assign ruibaby

```release-note
完整显示左侧菜单栏滚动条
```
@longjuan longjuan deleted the fix/menu-scroll-bar-is-blocked branch February 25, 2023 06:12
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023

#### What type of PR is this?
/kind improvement
/area console


#### What this PR does / why we need it:
使左侧菜单栏滚动条不被遮挡
#### Which issue(s) this PR fixes:

Fixes halo-dev#3272

#### Screenshots:
![image](https://user-images.githubusercontent.com/28662535/217997111-36676220-b539-417d-b606-a1fe336c9474.png)
![image](https://user-images.githubusercontent.com/28662535/217997152-165bb976-8cfa-480a-b27a-6478c2bad568.png)
![image](https://user-images.githubusercontent.com/28662535/217997216-820de8fb-9526-4e23-9fec-17e8f2e8ebab.png)

#### Special notes for your reviewer:
分为logo、可滚动(搜索、菜单)、用户信息三部分,不妥就关闭这个PR吧
#### Does this PR introduce a user-facing change?

```release-note
完整显示左侧菜单栏滚动条
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console端左侧菜单栏滚动条被遮挡
4 participants