This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
feat: update theme requires field and supports show failed message #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/feature
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, wzrove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…alo-dev/console#826) #### What type of PR is this? /kind feature #### What this PR does / why we need it: 修改主题的 `spec.require` 字段为 `spec.requires`，以及支持显示错误信息。适配：halo-dev#3150 #### Which issue(s) this PR fixes: Fixes halo-dev#3088 #### Screenshots: <img width="1692" alt="image" src="https://user-images.githubusercontent.com/21301288/212800478-0fe53ae8-4e31-4810-89aa-4b06d1b700fb.png"> <img width="1056" alt="image" src="https://user-images.githubusercontent.com/21301288/212800550-7edd7c0a-564c-4df4-baee-b3ffe6b3352d.png"> #### Special notes for your reviewer: 测试方式： 1. Halo 切换到 halo-dev#3150 分支。 2. Console 需要 `pnpm install`。 3. 修改主题的 `spec.requires`，根据 halo-dev#3150 中的测试条件修改这个值。 4. 检查是否可以显示异常版本信息。 #### Does this PR introduce a user-facing change? ```release-note Console 端支持显示主题的版本异常信息 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
修改主题的
spec.require字段为spec.requires，以及支持显示错误信息。适配：halo-dev/halo#3150Which issue(s) this PR fixes:
Fixes halo-dev/halo#3088
Screenshots:
Special notes for your reviewer:
测试方式：
pnpm install。spec.requires，根据 feat: support validate requires version for theme halo#3150 中的测试条件修改这个值。Does this PR introduce a user-facing change?