Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: login in safari browser has no effect #804

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 29, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复在 Safari 浏览器登录之后无反应的问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3002

Special notes for your reviewer:

测试方式:

  1. 在 Safari 浏览器上测试登录之后是否有跳转到仪表盘即可。

Does this PR introduce a user-facing change?

修复 Console 端在 Safari 浏览器登录之后无反应的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 29, 2022
@vercel
Copy link

vercel bot commented Dec 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Dec 29, 2022 at 1:14PM (UTC)

@ruibaby
Copy link
Member Author

ruibaby commented Dec 29, 2022

/cherry-pick release-2.0

@halo-dev-bot
Copy link

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Kapture 2022-12-29 at 21 24 06

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 4cb3a72 into halo-dev:main Dec 29, 2022
@ruibaby ruibaby deleted the fix/safari-login branch December 29, 2022 13:29
@halo-dev-bot
Copy link

@ruibaby: new pull request created: #808

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Dec 29, 2022
This is an automated cherry-pick of #804

/assign ruibaby

```release-note
修复 Console 端在 Safari 浏览器登录之后无反应的问题
```
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修复在 Safari 浏览器登录之后无反应的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3002

#### Special notes for your reviewer:

测试方式:

1. 在 Safari 浏览器上测试登录之后是否有跳转到仪表盘即可。

#### Does this PR introduce a user-facing change?

```release-note
修复 Console 端在 Safari 浏览器登录之后无反应的问题
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在 Safari 浏览器登录之后无法跳转
4 participants