This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
perf: improve the prompt for upload failure of the upload component #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JohnNiang
approved these changes
Dec 14, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
将这些修改应用到 release-2.0 分支如何？ |
|
/cherry-pick release-2.0 |
|
@ruibaby: new pull request created: #786 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…alo-dev/console#769) #### What type of PR is this? /kind improvement #### What this PR does / why we need it: 优化上传组件的异常提示信息。 #### Which issue(s) this PR fixes: Fixes halo-dev#2933 Ref halo-dev#2932 halo-dev#2931 #### Screenshots: <img width="794" alt="image" src="https://user-images.githubusercontent.com/21301288/207272593-b94efb0a-7033-4ec1-b1eb-f2e3871b34f0.png"> <img width="674" alt="image" src="https://user-images.githubusercontent.com/21301288/207272682-0c223d29-8c4f-45b0-a8d5-2432a97835c6.png"> #### Special notes for your reviewer: 测试方式： 1. 进入附件上传、插件安装、主题安装界面。 2. 上传不符合规则的文件，比如主题可以上传一个不是主题的 zip 或者 Halo 1.x 版本的 zip。 3. 观察是否有异常提示。 #### Does this PR introduce a user-facing change? ```release-note 优化 Console 端上传组件的异常提示信息。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
优化上传组件的异常提示信息。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#2933
Ref halo-dev/halo#2932 halo-dev/halo#2931
Screenshots:
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?