Skip to content

Commit

Permalink
Apply filter hook to results filter only (stashapp#4705)
Browse files Browse the repository at this point in the history
  • Loading branch information
WithoutPants authored and halkeye committed Sep 1, 2024
1 parent 0274fa5 commit 6f6aa0a
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions ui/v2.5/src/components/List/ItemList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export function makeItemList<T extends QueryResult, E extends IDataItem>({

const RenderList: React.FC<IItemListProps<T, E> & IRenderListProps> = ({
filter,
filterHook,
onChangePage: _onChangePage,
updateFilter,
persistState,
Expand All @@ -156,7 +157,14 @@ export function makeItemList<T extends QueryResult, E extends IDataItem>({
const [editingCriterion, setEditingCriterion] = useState<string>();
const [showEditFilter, setShowEditFilter] = useState(false);

const result = useResult(filter);
const effectiveFilter = useMemo(() => {
if (filterHook) {
return filterHook(cloneDeep(filter));
}
return filter;
}, [filter, filterHook]);

const result = useResult(effectiveFilter);
const [totalCount, setTotalCount] = useState(0);
const [metadataByline, setMetadataByline] = useState<React.ReactNode>();
const items = useMemo(() => getItems(result), [result]);
Expand Down Expand Up @@ -525,7 +533,6 @@ export function makeItemList<T extends QueryResult, E extends IDataItem>({
persistState,
persistanceKey = filterMode,
defaultSort = filterOptions.defaultSortBy,
filterHook,
defaultZoomIndex,
alterQuery = true,
} = props;
Expand Down Expand Up @@ -712,17 +719,11 @@ export function makeItemList<T extends QueryResult, E extends IDataItem>({
[filter, updateFilter]
);

const renderFilter = useMemo(() => {
if (filterInitialised) {
return filterHook ? filterHook(cloneDeep(filter)) : filter;
}
}, [filterInitialised, filter, filterHook]);

if (!renderFilter) return null;
if (!filterInitialised) return null;

return (
<RenderList
filter={renderFilter}
filter={filter}
onChangePage={onChangePage}
updateFilter={updateFilter}
{...props}
Expand Down

0 comments on commit 6f6aa0a

Please sign in to comment.