-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use le32/le64 #8344
Don't use le32/le64 #8344
Changes from 16 commits
ddd0189
60b46ee
3cce91f
24fd1b2
67d80ae
301c610
09fba5f
af4af91
8002729
30a755c
2cfd588
9325a2b
a9b0b61
4e5bd58
bfbe718
2e8a6e8
6401755
def7da0
0e766ae
3e99fb8
678164f
0c050b2
3ca975b
622c9cd
9885b30
6b6a76e
5b0ccc0
c88ab38
fe54bfe
b28acbc
97046ce
007186b
38f9ab6
2d5033b
39cd51d
55c3610
a2064e4
09c86a2
abbc1cd
b9497bd
d6affab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -217,17 +217,31 @@ foreach (i IN LISTS RUNTIME_CPP) | |
# unfortunately, clang doesn't automatically set this flag even though the | ||
# ABI is msvc on windows | ||
set(fshort-wchar -fshort-wchar) | ||
alexreinking marked this conversation as resolved.
Show resolved
Hide resolved
|
||
set(TARGET "le64-unknown-windows-unknown") | ||
if (LLVM_PACKAGE_VERSION VERSION_LESS 19.0) | ||
set(TARGET "le64-unknown-windows-unknown") | ||
else () | ||
# TODO: was le64 here, not sure if this is correct or not | ||
set(TARGET "aarch64-unknown-windows-unknown") | ||
endif () | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What prevents us from just using Also, does this introduce a requirement that LLVM be built with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Nothing AFAICT. I'll make the change.
Yes. |
||
endif () | ||
endif() | ||
# Everything else | ||
else() | ||
if (j EQUAL 32) | ||
# (The 'nacl' is a red herring. This is just a generic 32-bit little-endian target.) | ||
set(TARGET "le32-unknown-nacl-unknown") | ||
if (LLVM_PACKAGE_VERSION VERSION_LESS 19.0) | ||
if (j EQUAL 32) | ||
# generic 32-bit code | ||
set(TARGET "le32-unknown-nacl-unknown") | ||
else () | ||
# generic 64-bit code | ||
set(TARGET "le64-unknown-unknown-unknown") | ||
endif () | ||
else () | ||
# generic 64-bit code | ||
set(TARGET "le64-unknown-unknown-unknown") | ||
# don't be fooled: arm/aarch64 are just generic 32/64-bit targets for our purposes here | ||
if (j EQUAL 32) | ||
set(TARGET "arm-unknown-unknown-gnueabihf") | ||
else () | ||
set(TARGET "aarch64-unknown-unknown-unknown") | ||
endif () | ||
endif () | ||
endif () | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inconsistent with the CMake build, which uses
x86_64
instead ofaarch64
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed