Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert apparently-missing break; in IREquality.cpp #8211

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Insert apparently-missing break; in IREquality.cpp #8211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fffa28a
Insert apparently-missing `break;` in IREquality.cpp
steven-johnson Apr 29, 2024
3be0d43
Enable -Wimplicit-fallthrough
steven-johnson Apr 29, 2024
ed394d7
Also add -Wimplicit-fallthrough to runtime builds
steven-johnson Apr 29, 2024
871d3e7
Add missing break to runtime/webgpu.cpp
steven-johnson Apr 29, 2024
3445377
Also add flag to Makefile
abadams Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ function(set_halide_compiler_warnings NAME)
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wcast-qual>
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wignored-qualifiers>
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Woverloaded-virtual>
$<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wimplicit-fallthrough>

$<$<CXX_COMPILER_ID:GNU>:-Wsuggest-override>

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ WITH_RTTI ?= $(if $(LLVM_HAS_NO_RTTI),, not-empty)
RTTI_CXX_FLAGS=$(if $(WITH_RTTI), , -fno-rtti )

CXX_VERSION = $(shell $(CXX) --version | head -n1)
CXX_WARNING_FLAGS = -Wall -Werror -Wno-unused-function -Wcast-qual -Wignored-qualifiers -Wno-comment -Wsign-compare -Wno-unknown-warning-option -Wno-psabi -Wno-mismatched-new-delete
CXX_WARNING_FLAGS = -Wall -Werror -Wno-unused-function -Wcast-qual -Wignored-qualifiers -Wno-comment -Wsign-compare -Wno-unknown-warning-option -Wno-psabi -Wno-mismatched-new-delete -Wimplicit-fallthrough
ifneq (,$(findstring g++,$(CXX_VERSION)))
GCC_MAJOR_VERSION := $(shell $(CXX) -dumpfullversion -dumpversion | cut -f1 -d.)
GCC_MINOR_VERSION := $(shell $(CXX) -dumpfullversion -dumpversion | cut -f2 -d.)
Expand Down
1 change: 1 addition & 0 deletions src/IREquality.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ struct Comparer {
case IRNodeType::GT:
cmp(&GT::a);
cmp(&GT::b);
break;
case IRNodeType::GE:
cmp(&GE::a);
cmp(&GE::b);
Expand Down
1 change: 1 addition & 0 deletions src/runtime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ set(RUNTIME_CXX_FLAGS
-Wno-unused-function
-Wvla
-Wsign-compare
-Wimplicit-fallthrough
)

option(Halide_CLANG_TIDY_BUILD "Generate fake compile jobs for runtime files when running clang-tidy." OFF)
Expand Down
2 changes: 2 additions & 0 deletions src/runtime/webgpu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,7 @@ WEAK int halide_webgpu_run(void *user_context,
switch (arg_type.bits) {
case 1: {
*(int32_t *)arg_out = *((int8_t *)arg_in);
break;
}
case 8: {
*(int32_t *)arg_out = *((int8_t *)arg_in);
Expand All @@ -1048,6 +1049,7 @@ WEAK int halide_webgpu_run(void *user_context,
switch (arg_type.bits) {
case 1: {
*(uint32_t *)arg_out = *((uint8_t *)arg_in);
break;
}
case 8: {
*(uint32_t *)arg_out = *((uint8_t *)arg_in);
Expand Down
Loading