Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] Update to latest native headers #7932

Merged
merged 7 commits into from
Nov 28, 2023
Merged

[WebGPU] Update to latest native headers #7932

merged 7 commits into from
Nov 28, 2023

Conversation

jrprice
Copy link
Contributor

@jrprice jrprice commented Nov 3, 2023

  • Update mini_webgpu.h with latest version from Dawn
    • Document this process
  • Remove an argument from wgpuQueueOnSubmittedWorkDone

Fixes #7581

@jrprice jrprice mentioned this pull request Nov 3, 2023
Open
@jrprice
[WebGPU] Update to latest native headers
e6f72a9 
* Update mini_webgpu.h with latest version from Dawn
  * Document this process
* Remove an argument from wgpuQueueOnSubmittedWorkDone

Fixes halide#7581
@jrprice jrprice force-pushed the webgpu-header-update branch from c7fe63e to e6f72a9 Compare November 3, 2023 23:19
shoaibkamil
shoaibkamil reviewed Nov 4, 2023
View reviewed changes
README_webgpu.md Outdated Show resolved Hide resolved
shoaibkamil
shoaibkamil approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@shoaibkamil shoaibkamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it :) We need to update the dawn implementations on the buildbots, but I'll coordinate that with @abadams. Thanks for doing this!

@abadams
Copy link
Member

abadams commented Nov 10, 2023

I've updated dawn on both of the x86 mac buildbots we use for testing it. Doing a merge with main should clear up the buildbot failures.

@jrprice
Copy link
Contributor Author

jrprice commented Nov 13, 2023

Doing a merge with main should clear up the buildbot failures.

Done.

@abadams
Copy link
Member

abadams commented Nov 16, 2023

Looks like something's up with the async_device_copy correctness test with target host-webgpu

@steven-johnson
Copy link
Contributor

Debugging the failure on arm, it looks like the webgpu state_bar becomes bogus (the state_ptr is 0x2 rather than a valid ptr). Maybe a race condition for the async stuff (ie we are missing a barrier to force completion)? Not sure yet.

@steven-johnson
Copy link
Contributor

I'm updating Dawn (again) to the latest headers as the failing armbot had a stale version.

@steven-johnson steven-johnson merged commit 9ce5fd6 into halide:main Nov 28, 2023
3 checks passed
@jrprice jrprice deleted the webgpu-header-update branch November 28, 2023 21:21
@BrewTestBot BrewTestBot mentioned this pull request Feb 2, 2024
Closed
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@jrprice @steven-johnson @ardier
[WebGPU] Update to latest native headers (halide#7932)
edaf74d 
* [WebGPU] Update to latest native headers

* Update mini_webgpu.h with latest version from Dawn
  * Document this process
* Remove an argument from wgpuQueueOnSubmittedWorkDone

Fixes halide#7581

* [WebGPU] Note that wgpu is not yet supported

* [WebGPU] Add https:// to external links in README

* update to commit b5d38fc7dc2a20081312c95e379c4a918df8b7d4

* Update mini_webgpu.h

---------

Co-authored-by: Steven Johnson <srj@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoaibkamil shoaibkamil shoaibkamil approved these changes

@halidebuildbots halidebuildbots Awaiting requested review from halidebuildbots

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The process for generating mini_webgpu.h need documenting
4 participants
@jrprice @abadams @steven-johnson @shoaibkamil