Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutating if branches in isolation can break reachability analysis #7895

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Mutating if branches in isolation can break reachability analysis #7895

merged 2 commits into from
Oct 17, 2023

Conversation

abadams
Copy link
Member

@abadams abadams commented Oct 12, 2023

Fixes #7892

TH3CHARLie
TH3CHARLie approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the most interesting bug causes so far.

@TH3CHARLie
Copy link
Contributor

failures look like caused by LLVM

@abadams abadams merged commit db207b9 into main Oct 17, 2023
@BrewTestBot BrewTestBot mentioned this pull request Feb 2, 2024
Closed
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@abadams @ardier
Mutating if branches in isolation can break reachability analysis (ha…
ffaacea 
…lide#7895)

Fixes halide#7892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TH3CHARLie TH3CHARLie TH3CHARLie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong results with PredicateStores and RoundUp combinations
2 participants
@abadams @TH3CHARLie