Iterate over lets in the correct order in VectorizeLoops #7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (auto it = scope.cbegin(); it != scope.cend(); ++it) { | ||
| string vectorized_name = get_widened_var_name(it.name()); | ||
| Expr vectorized_value = mutate(it.value()); | ||
| for (auto let = containing_lets.begin(); let != containing_lets.end(); let++) { |
There was a problem hiding this comment.
Do we need to add comment(s) here and below about why we are doing this?
There was a problem hiding this comment.
I updated the comments, but it really was just my mistake incorrectly assuming that Scope preserves insertion order (which it does but only within specific name).
steven-johnson
approved these changes
Sep 1, 2023
|
Looks like failure are unrelated, going to merge in. |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Iterate over lets in correct order * Comments * Comments * Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to iterate over vars in insertion order, but the Scope doesn't preserver the order.
Fixes #7779