Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HAL-1952] Adding String constants in ExpressionEncryptor class. #1026

Merged
merged 3 commits into from
Dec 4, 2023
Merged

[HAL-1952] Adding String constants in ExpressionEncryptor class. #1026

merged 3 commits into from
Dec 4, 2023

Conversation

SarafrazAhamad
Copy link

…rypt Expression code in the ExpressionEncryptor class

[HAL-1952] Adding String constants have been used directly in the Enc…
cef84d3 
…rypt Expression code in the ExpressionEncryptor class
@SarafrazAhamad SarafrazAhamad requested a review from a team as a code owner December 4, 2023 13:19
hpehl
hpehl requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@hpehl hpehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather add the constants to org.jboss.hal.dmr.ModelDescriptionConstants and reference them.

@SarafrazAhamad
Copy link
Author

@hpehl - Thank you for your input. I will do the same and then submit the pull request.

[HAL-1952] Adding String constants have been used directly in the Enc…
3c5b1c1 
…rypt Expression code in the ExpressionEncryptor class
hpehl
hpehl requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@hpehl hpehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being picky, but the constants in ModelDescriptionConstants are sorted by name. Could you please reorder the new constants accordingly? Thanks!

[HAL-1952] Adding String constants have been used directly in the Enc…
106ed8a 
…rypt Expression code in the ExpressionEncryptor class
@SarafrazAhamad
Copy link
Author

@hpehl - The changes were completed as per the request and committed the changes.

hpehl
hpehl approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@hpehl hpehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @SarafrazAhamad

@hpehl hpehl merged commit f5064a5 into hal:main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpehl hpehl hpehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SarafrazAhamad @hpehl