Email alert #35
Open
Email alert #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/alert/mail/main.c
Outdated
| #include <string.h> | ||
| #include <curl/curl.h> | ||
|
|
||
| #define FROM "<haka@alert.com>" |
There was a problem hiding this comment.
Maybe we should set it in configuration.
Set a default to alert.com could be annoying for alert.com owner. A reasonable default could be to use local hostname.
nabilbendafi
force-pushed
the
develop
branch
2 times, most recently
from
3904718 to
97ce373
Compare
- Split initialisation and cleanup
- No authentication method - STARTTLS authentication method
- Set it at runtime (not at compilation time)
- Compute it only once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose a fix for #18. It sends each alert as single email.
Might be improved, but can be a good starter.