Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing js build tag #1088

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Fix missing js build tag #1088

merged 1 commit into from
Feb 21, 2020

Conversation

tomlister
Copy link
Contributor

Added js to build tags as suggested by @hajimehoshi

@tomlister
Fix missing js build tag
7c5bb9b 
Added js to build tags as suggested by @hajimehoshi
@tomlister tomlister mentioned this pull request Feb 21, 2020
Closed
hajimehoshi
hajimehoshi approved these changes Feb 21, 2020
View reviewed changes
Copy link
Owner

@hajimehoshi hajimehoshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Let's wait and see the build bots do not complain.

@tomlister
Copy link
Contributor Author

Awesome, looking forward to contributing in the future.

@hajimehoshi hajimehoshi merged commit 3eea196 into hajimehoshi:master Feb 21, 2020
hajimehoshi pushed a commit that referenced this pull request Feb 21, 2020
@tomlister @hajimehoshi
Fix missing js build tag (#1088)
ff9e0d6 
Added js to build tags as suggested by @hajimehoshi

Fixes #1087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajimehoshi hajimehoshi hajimehoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomlister @hajimehoshi