-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API DTO Implementation #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, appreciate the effort!
Any ETA on this PR? Does it have blockers that you could need help with? |
@Shentoza But as I aim to make it cross-technologies, I'm waiting for the UnitNet C# owner to provide their input before publishing and committing to the new API. Since I don't know when he will give his input, if it helps, I can publish the new API as a beta release, with no guarantee of slight changes before the final release (unlikely, but still possible) WDYT? |
That makes totally sense to wait if the C# package owner agrees to your approach, which would be great. For now i have a working solution™, so it's not urgent, and I will just swap out once this PR completes. |
since I seem to be the only one interested in this change, i dont think it justifies a beta/bleeding edge branch and for stability reasons, i would wait for the stable release anyway, so i dont have to update twice |
The JS implementation of #31
See also the discussion on angularsen/UnitsNet#1378