Merge batch #4414
Merged
Merge batch #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated logging
(unused) bidict jupyter deployment
some cleanup
* test * added git to pr-builder image
* wip: added job/delete need to test * added delete, various
* make batch single threaded polling and k8s watch thread request into main thread in addition to k8s notifications, periodically poll k8s state * address comments
* added hail-ci-deploy.sh add docker to pr-builder image * added missing deployment.yaml.in removed deployment.yaml * consistency * addessed comments
`gcloud components install kubectl` is failing with a non-obvious error message so I installed it directly
* make batch subproject fixed more deployment bugs * updated build image * fix test race condition job can complete before it is cancelled
* authenticate docker to push to gcr.io * add gcloud quiet (-q) * remove errant tab * logging to match ci * do callback asynchronously * do callback asynchronously
* Update hail-ci-deploy.sh * Update deployment.yaml.in * Update hail-ci-deploy.sh * Update hail-ci-deploy.sh
* add /jobs/<id>/log endpoint added to api, client return completed job logs (including deleted ones) return in-progress logs (if there are any) return 404 (not empty) if there no logs to be found status['log'] returns the same log * fixed bug * fixed typo
clean up unused files, experiments (jupyter, spark, etc.)
|
I pushed another commit. Toplevel hail-ci-build.sh handles all known projects (and skips them if they aren't there yet or don't have a build script). Also, deploy batch only when changed. I will also make this generic by adding a get-deployed-sha.sh to retrieve the current deployed sha to compare against when considering redeploy. |
danking
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of hail-is/batch master updating only hail-ci-{build, deploy}.sh to resolve merge conflicts.