move annotate(struct1, struct2) to IR

[catoverdrive]

this moves the struct-level annotate that's in the AST (which calls tstruct1.annotate(tstruct2)) This will allow the python struct-level annotate operation to pass through the IR when able.

[danking]

@cseed why are these specially called out? They should always fail to be found in the function registry nor are they primitive operations.

[catoverdrive]

I think this has to do with incomplete typechecking of the arguments of these methods.

[danking]

Why is this special? is there something wrong with doing primo conversion on it?

[catoverdrive]

The AST for Apply("annotate", Seq(structA,structB)) doesn't place limitations on what structB is, since it just uses structA.typ.annotate(structB.typ). I don't want to handle the general case, so I'm only converting in the case that the annotate node looks like Apply("annotate", Seq(structA, StructConstructor(...))), which is I believe enough to handle all of our current uses in the Python.

[danking]

will something like this work?

def maybeFindIRFunction(fn: String, args: Seq[AST]): Option[IR] = for {
  irArgs <- anyFailAllFail(args.map(_.toIR(agg)))
  ir <- tryPrimOpConversion(args.map(_.`type`).zip(irArgs)).orElse(
    IRFunctionRegistry.lookupFunction(fn, args.map(_.`type`))
      .map { irf => irf(irArgs) })
} yield ir

and

fn match {
  // ...
  case "annotate" =>
    if (!args(1).isInstanceOf[StructConstructor])
      None
    else
      maybeFindIRFunction(fn, args)
  case _ =>
    maybeFindIRFunction(fn, args)

?

[catoverdrive]

yes. I'll change.

[danking]

will something like this work?

def maybeFindIRFunction(fn: String, args: Seq[AST]): Option[IR] = for {
  irArgs <- anyFailAllFail(args.map(_.toIR(agg)))
  ir <- tryPrimOpConversion(args.map(_.`type`).zip(irArgs)).orElse(
    IRFunctionRegistry.lookupFunction(fn, args.map(_.`type`))
      .map { irf => irf(irArgs) })
} yield ir

and

fn match {
  // ...
  case "annotate" =>
    if (!args(1).isInstanceOf[StructConstructor])
      None
    else
      maybeFindIRFunction(fn, args)
  case _ =>
    maybeFindIRFunction(fn, args)

?

fixed

[danking]

this should be private[this] since it's not intended to be used by other classes.

addressed