implement annotate/drop in terms of select_entries #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-schultz
previously requested changes
Mar 21, 2018
|
|
||
| ids = [] | ||
| for e in exprs: |
There was a problem hiding this comment.
It doesn't look like anything in exprs is getting passed to _select_entries. I might be missing something, but if not you should add a test that fails, and then fix select_entries to make it pass.
python/hail/matrixtable.py
Outdated
| # need to drop entry fields | ||
| m = MatrixTable(m._jvds.dropEntries(entry_fields)) | ||
|
|
||
|
|
There was a problem hiding this comment.
Why so much space?
catoverdrive
dismissed
patrick-schultz’s stale review
good call. thanks for catching that!
patrick-schultz
approved these changes
Mar 22, 2018
jbloom22
pushed a commit
to jbloom22/hail
that referenced
this pull request
Mar 22, 2018
* rewrite MatrixTable.selectEntries to take single expr * remove annotateEntriesExpr and dropEntries from scala MatrixTable * python wip * wip * wip * fixed selectEntries bug * cleanup * fix * fix select_entries
konradjk
pushed a commit
to konradjk/hail
that referenced
this pull request
Jun 12, 2018
* rewrite MatrixTable.selectEntries to take single expr * remove annotateEntriesExpr and dropEntries from scala MatrixTable * python wip * wip * wip * fixed selectEntries bug * cleanup * fix * fix select_entries
jackgoldsmith4
pushed a commit
to jackgoldsmith4/hail
that referenced
this pull request
Jun 25, 2018
* rewrite MatrixTable.selectEntries to take single expr * remove annotateEntriesExpr and dropEntries from scala MatrixTable * python wip * wip * wip * fixed selectEntries bug * cleanup * fix * fix select_entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.