Add lower/upper/strip/contains to StringExpression #3199
Conversation
| @@ -2048,6 +2048,75 @@ def split(self, delim, n=None): | |||
| else: | |||
| return self._method("split", tarray(tstr), delim, n) | |||
|
|
|||
| def lower(self): | |||
| """Returns a string of only lower-case characters. | |||
There was a problem hiding this comment.
can this be something like "Returns a string with all letters converted to lowercase." or something? (Basically making it more clear that it's performing an action on the given string---I got a little confused because s is defined quite a ways up.) Ditto for upper.
There was a problem hiding this comment.
how about this (copied from Python stdlib docs):
Return a copy of s, but with upper case letters converted to lower case.
There was a problem hiding this comment.
sounds good! I don't have strong feelings about exact verbiage.
| registerMethod("lower", (s: String) => s.toLowerCase) | ||
| registerMethod("upper", (s: String) => s.toUpperCase) | ||
| registerMethod("strip", (s: String) => s.trim()) | ||
| registerMethod("contains", (s: String, t: String) => s.contains(t)) |
There was a problem hiding this comment.
I want to be difficult: no new FunctionRegistry methods without corresponding IR methods.
There was a problem hiding this comment.
can you point me to the code to mimic?
There was a problem hiding this comment.
in is.hail.expr.ir.functions. You probably want a StringFunctions to mimic MathFunctions, and then you need to call registerAll in IRFunctionRegistry.
* Add lower/upper/strip/contains to StringExpression * added StringFunctions IR
* Add lower/upper/strip/contains to StringExpression * added StringFunctions IR
* Add lower/upper/strip/contains to StringExpression * added StringFunctions IR
No description provided.