Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hopefully fix dylib issue #3195

Merged
merged 1 commit into from
Mar 21, 2018
Merged

hopefully fix dylib issue #3195

merged 1 commit into from
Mar 21, 2018

Conversation

danking
Copy link
Contributor

@danking danking commented Mar 20, 2018

If this dylib isn't checked in, it isn't generated by the linux machine (since they're not OS X machines) and never copied into the distributions, so the distributions will never be able to run IBD on OS X machines.

@danking
Copy link
Contributor Author

danking commented Mar 20, 2018

cc: @cseed you had a seemingly unrelated PR that removed this originally (July of 2017), just want to make sure that wasn't intentional.

@tpoterba
Copy link
Contributor

I think 0.1 builds are broken at the moment, Jackie was going to fix as part of her open PR

@tpoterba tpoterba merged commit 62417f4 into hail-is:master Mar 21, 2018
jbloom22 pushed a commit to jbloom22/hail that referenced this pull request Mar 22, 2018
konradjk pushed a commit to konradjk/hail that referenced this pull request Jun 12, 2018
jackgoldsmith4 pushed a commit to jackgoldsmith4/hail that referenced this pull request Jun 25, 2018
@danking danking deleted the fix-dylib-issue branch December 18, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants