Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query/vds] Fix removal of ref GT in from_merged_representation #14699

Closed

Conversation

chrisvittal
Copy link
Collaborator

We can't do this anymore since genotype may be something other than diploid.

Missed this in the original VDS ploidy changes

Split off from #14675 to shrink that change to assist in debugging it.

We can't do this anymore since genotype may be something other than
diploid.

Missed this in the original VDS ploidy changes
Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix.

@chrisvittal chrisvittal mentioned this pull request Sep 25, 2024
1 task
@chrisvittal
Copy link
Collaborator Author

@cjllanwarne this is a small bugfix that I would like to have in the release, and it is/was a part of #14675 that's you've already approved, so, could I get a thumb?

@chrisvittal
Copy link
Collaborator Author

closing in favor of #14675 which includes this change

@chrisvittal chrisvittal closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants