Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Remove wheel dependence on setuptools #14631

Merged

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Jul 22, 2024

hail had a transitive dependency on setuptools via an ancient version of humanize that's removed by upgrading to the latest major revision.
Bump humanize to major revision 4 and regenerate lock files.

Fixes #14630

@ehigham
Copy link
Member Author

ehigham commented Jul 22, 2024

Tested by installing wheel in clean venv, importing and running basic hail commands

Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. You say this removes our dependence on setuptools, but I only see version bumps. Can you explain how this fixes the bug reported in #14630?

Also, it would be helpful to record for history what you ran to update all the pinned-requirements.txt files.

@ehigham
Copy link
Member Author

ehigham commented Jul 29, 2024

Description updated.

Also, it would be helpful to record for history what you ran to update all the pinned-requirements.txt files.

$ make generate-pip-lockfiles

@ehigham ehigham requested a review from patrick-schultz July 29, 2024 19:52
Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@iris-garden iris-garden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced original error by building a wheel locally off of main and installing it into a new miniconda env without setuptools:

make -C hail shadowJar wheel HAIL_RELEASE_MODE=1
yes | conda create -n hail-test python=3.9
conda activate hail-test
pip uninstall setuptools
pip install hail/build/deploy/dist/hail-0.2.132-py3-none-any.whl
python -c "import hail"

Then ran the same commands on this branch, and confirmed there was no error.

Thanks for fixing this!

@hail-ci-robot hail-ci-robot merged commit ee6d17e into hail-is:main Jul 30, 2024
4 checks passed
@ehigham ehigham deleted the ehigham/fixes/14630-broken-pypi-install branch July 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing from PyPI leads to a broken install
4 participants