-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] Remove wheel dependence on setuptools
#14631
[misc] Remove wheel dependence on setuptools
#14631
Conversation
Tested by installing wheel in clean venv, importing and running basic hail commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. You say this removes our dependence on setuptools, but I only see version bumps. Can you explain how this fixes the bug reported in #14630?
Also, it would be helpful to record for history what you ran to update all the pinned-requirements.txt
files.
Description updated.
$ make generate-pip-lockfiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproduced original error by building a wheel locally off of main
and installing it into a new miniconda env without setuptools
:
make -C hail shadowJar wheel HAIL_RELEASE_MODE=1
yes | conda create -n hail-test python=3.9
conda activate hail-test
pip uninstall setuptools
pip install hail/build/deploy/dist/hail-0.2.132-py3-none-any.whl
python -c "import hail"
Then ran the same commands on this branch, and confirmed there was no error.
Thanks for fixing this!
hail
had a transitive dependency onsetuptools
via an ancient version ofhumanize
that's removed by upgrading to the latest major revision.Bump
humanize
to major revision4
and regenerate lock files.Fixes #14630