Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Use importlib.resources instead of pkg_resources #14449

Merged
merged 5 commits into from
Apr 11, 2024
Merged

[python] Use importlib.resources instead of pkg_resources #14449

merged 5 commits into from
Apr 11, 2024

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Apr 5, 2024 •
edited
Loading

Fixes: #14428

@daniel-goldstein daniel-goldstein self-requested a review April 9, 2024 15:40
daniel-goldstein
daniel-goldstein approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@daniel-goldstein daniel-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@hail-ci-robot hail-ci-robot merged commit 521ca1a into hail-is:main Apr 11, 2024
2 checks passed
@ehigham ehigham deleted the ehigham/14428-python-setuptools branch April 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-goldstein daniel-goldstein daniel-goldstein approved these changes

Assignees

@daniel-goldstein daniel-goldstein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Hail seems to need setuptools at runtime, but does not have it listed as a dependency
3 participants
@ehigham @daniel-goldstein @hail-ci-robot