Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[batch] Do not lock when querying billing projects #14443

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[batch] Do not lock when querying billing projects #14443

merged 1 commit into from
Apr 4, 2024

Conversation

daniel-goldstein
Copy link
Contributor

Decided to tackle this as it was causing noise in the logs. There is no reason this read-only select query should lock any rows.

@hail-ci-robot hail-ci-robot merged commit e7c152a into hail-is:main Apr 4, 2024
2 checks passed
This was referenced Apr 4, 2024
Closed
Merged
hail-ci-robot pushed a commit that referenced this pull request Apr 11, 2024
@daniel-goldstein
[batch] Remove remaining locks in read-only billing project queries (#…
dcb83f6 
…14458)

I missed that #14443 only got one of several `LOCK IN SHARE MODE` lines
in the billing projects query. This gets the rest in the two
`query_billing_projects` functions that do readonly selects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehigham ehigham ehigham approved these changes

Assignees

@ehigham ehigham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-goldstein @ehigham @hail-ci-robot