Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Don't error on VCF export when haploid call is unphased #14375

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[query] Don't error on VCF export when haploid call is unphased #14375

merged 1 commit into from
Feb 29, 2024

Conversation

chrisvittal
Copy link
Collaborator

resolves #14330

ehigham
ehigham approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@ehigham ehigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@danking danking merged commit aae8027 into hail-is:main Feb 29, 2024
2 checks passed
@shengqh
Copy link

shengqh commented Feb 29, 2024

When will it be available to use?

@MattWellie MattWellie mentioned this pull request Mar 26, 2024
Merged
3 tasks
@ehigham
Copy link
Member

ehigham commented Mar 28, 2024

When will it be available to use?

0.2.129. Should be released soon,

@patrick-schultz patrick-schultz mentioned this pull request Apr 1, 2024
Merged
This was referenced Apr 25, 2024
Closed
Closed
Open
chrisvittal added a commit that referenced this pull request Jul 10, 2024
@chrisvittal
[query] Don't error on VCF export when haploid call is unphased (#14375)
cf83e0f 
resolves #14330
chrisvittal added a commit that referenced this pull request Jul 10, 2024
@chrisvittal
[query] Don't error on VCF export when haploid call is unphased (#14375)
d13028f 
resolves #14330
chrisvittal added a commit that referenced this pull request Jul 11, 2024
@chrisvittal
[query] Don't error on VCF export when haploid call is unphased (#14375)
0a37fd5 
resolves #14330
chrisvittal added a commit that referenced this pull request Jul 11, 2024
@chrisvittal
Release 0.2.127.terra
28c375d 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
chrisvittal added a commit that referenced this pull request Jul 15, 2024
@chrisvittal
Release 0.2.127.terra
4a75395 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
chrisvittal added a commit that referenced this pull request Jul 15, 2024
@chrisvittal
Release 0.2.127.terra
7f5ecb6 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
chrisvittal added a commit that referenced this pull request Jul 15, 2024
@chrisvittal
Release 0.2.127.terra
8d1c3e3 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
chrisvittal added a commit that referenced this pull request Jul 15, 2024
@chrisvittal
Release 0.2.127.terra
ed21603 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
chrisvittal added a commit that referenced this pull request Jul 15, 2024
@chrisvittal
Release 0.2.127.post1
97a98f7 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
chrisvittal added a commit that referenced this pull request Jul 15, 2024
@chrisvittal
Release 0.2.127.post1
d36a052 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
chrisvittal added a commit that referenced this pull request Jul 15, 2024
@chrisvittal
Release 0.2.127.post1
9d4080a 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
   - [annotationdb][datasets] regional buckets (#14286)
chrisvittal added a commit that referenced this pull request Jul 15, 2024
@chrisvittal
Release 0.2.127.post1
0238972 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
   - [annotationdb][datasets] regional buckets (#14286)
chrisvittal added a commit that referenced this pull request Jul 16, 2024
@chrisvittal
Release 0.2.127.post1
557102d 
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [query] Don't error on VCF export when haploid call is unphased (#14375)
   - [compiler] apply scalafix to all scala sources (#14156)
   - [annotationdb][datasets] regional buckets (#14286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehigham ehigham ehigham approved these changes

Assignees

@ehigham ehigham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[query] Erroneous error on export_vcf when exporting haploid calls
4 participants
@chrisvittal @shengqh @ehigham @danking