[release] Use consistent directory naming for azure wheel #14325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
previously requested changes
Feb 22, 2024
There was a problem hiding this comment.
If you ripgrep case insensitive for wheel[-_]f there's a few more spots we should fix:
/Users/dking/projects/hail/hail/scripts/release.sh:23: WHEEL_FOR_AZURE \\
/Users/dking/projects/hail/hail/scripts/release.sh:48:WHEEL_FOR_AZURE=${13}
/Users/dking/projects/hail/hail/scripts/release.sh:133:wheel_for_azure_url=gs://hail-common/azure-hdinsight-wheels/$(basename $WHEEL_FOR_AZURE)
/Users/dking/projects/hail/hail/scripts/release.sh:134:gcloud storage cp $WHEEL_FOR_AZURE $wheel_for_azure_url
/Users/dking/projects/hail/hail/scripts/release.sh:135:gcloud storage objects update $wheel_for_azure_url --temporary-hold
/Users/dking/projects/hail/hail/Makefile:427:# set WHEEL_FOR_AZURE to the path to that wheel file
/Users/dking/projects/hail/hail/Makefile:446: $(WHEEL_FOR_AZURE) \
danking
approved these changes
Feb 22, 2024
|
Going to stack on #14322 since it adds an occurence of WHEEL_FOR_AZURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes hand running the release slightly less error-prone.