[query] Add isIsomorphicTo for virtual types
#14265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehigham
commented
Feb 8, 2024
chrisvittal
reviewed
Feb 12, 2024
hail/src/main/scala/is/hail/types/physical/stypes/concrete/SStackStruct.scala
Outdated
Show resolved
Hide resolved
chrisvittal
previously requested changes
Feb 12, 2024
ehigham
changed the title
isIsomorphicTo for virtual and stack typesisIsomorphicTo for virtual types
ehigham
dismissed
chrisvittal’s stale review
Bailed out of SType change, though the change for virtual types is still useful.
chrisvittal
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to know when types are isomorphic to one-another for cast-rename operations.
We had a method of the same name in
TBaseStructthat did't really do isomorphism as it included names in field types.I've renamed this to
isJoinableWithas a consequence.