Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hailtop] allow configuration of default HTTP timeout #14206

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

danking
Copy link
Contributor

@danking danking commented Jan 29, 2024

Until we have a mechanism to infer the correct timeout based on network conditions, this provides an escape hatch for users on flaky network connections such as wifi.

Until we have a mechanism to infer the correct timeout based on network conditions, this provides an
escape hatch for users on flaky network connections such as wifi.
@danking
Copy link
Contributor Author

danking commented Jan 29, 2024

Confirmed that the hailctl bit works:

(base) dking@wm28c-761 hail % hailctl config set http/timeout_in_seconds 1234s
Error: bad value '1234s' for parameter <ConfigVariable.HTTP_TIMEOUT_IN_SECONDS: 'http/timeout_in_seconds'> should be a float or an int like 42.42 
or 42
(base) dking@wm28c-761 hail % hailctl config set http/timeout_in_seconds 42   
(base) dking@wm28c-761 hail % hailctl config set http/timeout_in_seconds 42.0
(base) dking@wm28c-761 hail % hailctl config set http/timeout_in_seconds 60  
(base) dking@wm28c-761 hail % cat ~/.config/hail/config.ini                
[query]
backend = spark
jar_url = gs://hail-query-ger0g/jars/dking/uk4prwgezgva/5fc88d5a4b614454004226f5c77ea72efee1e38f.jar

[batch]
remote_tmpdir = gs://1-day/
billing_project = hail
backend = service

[aiocloudflare]

[global]
domain = hail.is

[gcs_requester_pays]
project = broad-ctsa

[http]
timeout_in_seconds = 60

@danking danking merged commit 4324736 into hail-is:main Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants