[query] fix remaining scala warnings #14188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvittal
previously requested changes
Jan 22, 2024
| @@ -455,7 +447,6 @@ object ServiceBackendAPI { | |||
| assert(argv.length == 7, argv.toFastSeq) | |||
|
|
|||
| val scratchDir = argv(0) | |||
| val logFile = argv(1) | |||
There was a problem hiding this comment.
Is there any documentation as to what these argv mean other than the code? It seems easy to forget the meaning of these arguments otherwise.
Comment on lines
-107
to
-108
| val logFile = argv(1) | ||
| var jarLocation = argv(2) |
| @@ -28,7 +28,7 @@ abstract class StateMachine[A] { | |||
| object StateMachine { | |||
| def terminal[A]: StateMachine[A] = new StateMachine[A] { | |||
| val isValid = false | |||
| var value: A = _ | |||
| val value: A = ??? | |||
There was a problem hiding this comment.
This errors every time terminal is called.
chrisvittal
approved these changes
Jan 25, 2024
chrisvittal
pushed a commit
to chrisvittal/hail
that referenced
this pull request
Jul 10, 2024
chrisvittal
pushed a commit
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.