Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the dates of recent releases #14161

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

jmarshall
Copy link
Contributor

No description provided.

@jmarshall
Copy link
Contributor Author

The recent PR #14086 was added to for a month before it was merged and the release made on Jan 12th. However the release date listed in the changelog remained the Released 2023-12-08 date on which the PR was initiated.

If there is a checklist for making releases, it may be worth adding “Update the release date in change_log.md before merging the release PR” to it.

@@ -318,7 +318,7 @@ Released 2023-05-30

## Version 0.2.117

Released 2023-05-19
Released 2023-05-23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is 2023-05-22 -- could be a timezone difference.

Copy link
Contributor Author

@jmarshall jmarshall Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a toss-up between the datestamp of the commit (Mon May 22 21:34:45 2023 -0400) and the datestamp of the tag (Tue May 23 02:19:17 2023 +0000).

However on revisiting this I notice the +0000: the automation-based tagging does not get set to appear as being done in the Hail repo's home timezone and actually occurred within an hour of the commit, indeed on your 22nd. Thanks.

@danking danking merged commit ad3ccdf into hail-is:main Jan 19, 2024
5 checks passed
@jmarshall jmarshall deleted the rel-dates branch January 22, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants