[doctest] reduce doctest setup time #14111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, testing just the n_partitions method of Table takes nearly a minute, 52s of
which is spent in "setup". Admittedly, this setup is shared across multiple tests, but this is an
unacceptable burden for iterating on one method.
```
52.30s setup hail/table.py::hail.table.Table.n_partitions
3.07s call hail/table.py::hail.table.Table.n_partitions
```
After this change, the setup time significantly reduces. The call gets slower, presumably because
the JVM is not warm. I think the setup time is now dominated by Hail JVM initialization.
```
11.77s call hail/table.py::hail.table.Table.n_partitions
9.68s setup hail/table.py::hail.table.Table.n_partitions
```
This reduces the practical runtime of this test by 50%.
This commit adds 72kB to the repository:
```
$ git diff-tree -r -c -M -C --no-commit-id HEAD | awk '{print $4}' | git cat-file --batch-check | awk 'BEGIN {s=0} {s+= $3} END {print s}'
72998
```
|
bump |
patrick-schultz
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, testing just the n_partitions method of Table takes nearly a minute, 52s of which is spent in "setup". Admittedly, this setup is shared across multiple tests, but this is an unacceptable burden for iterating on one method.
After this change, the setup time significantly reduces. The call gets slower, presumably because the JVM is not warm. I think the setup time is now dominated by Hail JVM initialization.
This reduces the practical runtime of this test by 50%.
This commit adds 72kB to the repository: