Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hailctl] make hailctl work on windows #14090

Merged
merged 3 commits into from
Dec 8, 2023
Merged

[hailctl] make hailctl work on windows #14090

merged 3 commits into from
Dec 8, 2023

Commits on Dec 8, 2023

  1. [hailctl] make hailctl work on windows 

    1. Non 64-bit Windows uses "Program Files" not "Program Files (x86)"

2. Windows Subsystem for Linux looks like GNU/Linux but will not have chromium on its path.

3. The removed arguments are no longer supported. They produce a warning message in my version of Chrome and appear to not work in the version of Chrome that this user was using. Instead, I bind to 0.0.0.0 and access the Notebook using the machine DNS name. This is how Google recommend accessing the Spark UI anyway.
    Dan King committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f72d764 View commit details
    Browse the repository at this point in the history

  2. adjust tests for new domain name

    Dan King committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a83d72b View commit details
    Browse the repository at this point in the history

  3. fix

    Dan King committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    92c81b6 View commit details
    Browse the repository at this point in the history