[hailtop] Remove namespace options in hailctl auth commands #14069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-goldstein
force-pushed
the
rely-less-on-default-namespace-everywhere
branch
from
a3ef087
to
8a114de
Compare
danking
previously requested changes
Dec 7, 2023
hail/python/hailtop/auth/auth.py
Outdated
| json=body | ||
| ) | ||
| url = get_deploy_config().url('auth', f'/api/v1alpha/users/{username}/create') | ||
| async with hail_session() as session: |
There was a problem hiding this comment.
I think we maybe purposely gave extra timeout for this API call.
There was a problem hiding this comment.
I forgot these weren't immediate operations. I restored the timeouts.
| deploy_config.url('auth', f'/api/v1alpha/users/{username}') | ||
| ) | ||
| async def async_delete_user(username: str): | ||
| url = get_deploy_config().url('auth', f'/api/v1alpha/users/{username}') |
There was a problem hiding this comment.
no, restored the timeout
danking
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to move our codebase away from relying on the notion of a K8s namespace for routing because this model does not hold in alternative deployment environments such as Terra. Further, having a
-noption inhailctl authcommands is awkward because it can only be used for dev environments yet is visible to users in the help menu. As such, this is a breaking change only for developers. The functionality is not really gone though because you can replace anyhailctl auth … -n dgoldstewithHAIL_DEFAULT_NAMESPACE=dgoldste hailctl auth ….