Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tooling] adds non-hailtop subdirs to pylint ignore #14060

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

iris-garden
Copy link
Contributor

We only have make commands for running pylint on subdirectories that have been kept up to date with its rules, but the pylintrc doesn't actually contain any indication of which subdirectories should be ignored when running pylint. This makes the use of language servers that run pylint on the file that's open frustrating, as files in the ignored subdirectories will often be full of pylint suggestions. This change adds the relevant subdirectories to the pylintrc file. Note that this does not necessarily enable us to run pylint directly on those subdirectories with the equivalent make commands to the ones that already exist, because there is no way that I've found to make pylint ignore the __init__.py file of whatever module it's being run on, so running it on hail/python/hail, for example, produces many errors.

@danking danking merged commit 4c0dc9a into hail-is:main Dec 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants