Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Turn dry run off on artifact registry cleanup policies #14001

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

jigold
Copy link
Contributor

@jigold jigold commented Nov 9, 2023

No description provided.

Copy link
Contributor

@daniel-goldstein daniel-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just also make sure that the invocation in release.sh is working as expected, or else we're going to accidentally revert this value when we release.

@jigold
Copy link
Contributor Author

jigold commented Nov 15, 2023

(py311) jigold@wm349-8c4 hail % gcloud artifacts repositories set-cleanup-policies hail \
    --project=hail-vdc \
    --location=us \
    --policy=/Users/jigold/projects/hail/infra/gcp-broad/gcp-ar-cleanup-policy.txt \
    --no-dry-run
WARNING:  Python 3.5-3.7 will be deprecated on August 8th, 2023. Please use Python version 3.8 and up.

If you have a compatible Python interpreter installed, you can use it by setting
the CLOUDSDK_PYTHON environment variable to point to it.

Updated repository [hail].
Dry run is disabled.

I checked the UI and it seems correct now.
Screenshot 2023-11-15 at 7 50 06 AM

@jigold
Copy link
Contributor Author

jigold commented Nov 15, 2023

I confirmed the terraform plan is clean now so dry run is off.

@danking danking merged commit e9e8e17 into hail-is:main Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants